Adjust tolerances and asserts #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows test_export_best.py to pass on Windows. The docs say os.linesep should not be used when writing text files. "\n" is converted to the appropriate ending automatically. https://docs.python.org/3/library/os.html#os.linesep
Codecov Report
@@ Coverage Diff @@
## master #1601 +/- ##
==========================================
- Coverage 66.62% 66.62% -0.01%
==========================================
Files 614 614
Lines 68725 68724 -1
Branches 9567 9567
==========================================
- Hits 45789 45788 -1
- Misses 21007 21008 +1
+ Partials 1929 1928 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tolerance and expected output asserts are adjusted to allow tests to pass on Windows.
The
test_missing_reflections.pyplatform difference might be a concern.