-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid crashes on Windows when printing unicode #1602
Conversation
where the output is redirected away from the console into a pipe or file. For this we need to ensure that stdout/stderr are UTF-8 encoded.
Codecov Report
@@ Coverage Diff @@
## master #1602 +/- ##
==========================================
- Coverage 66.62% 66.61% -0.02%
==========================================
Files 614 614
Lines 68725 68734 +9
Branches 9567 9568 +1
==========================================
- Hits 45789 45788 -1
- Misses 21007 21017 +10
Partials 1929 1929 |
It's a big improvement! Before:
After:
I'm mainly left with cosym test failures, but these seem new to me - maybe related to #1581. I'll look into more details on Monday. The |
where the output is redirected away from the console into a pipe or
file. For this we need to ensure that stdout/stderr are UTF-8 encoded.