Label rlp #1614
Merged
Label rlp #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dials.rl_png and test_render_3d expect set_points as is, so move the additions to a new function.
Codecov Report
@@ Coverage Diff @@
## main #1614 +/- ##
==========================================
- Coverage 66.61% 66.59% -0.03%
==========================================
Files 614 614
Lines 68771 68803 +32
Branches 9574 9578 +4
==========================================
+ Hits 45813 45816 +3
- Misses 21027 21056 +29
Partials 1931 1931 |
toastisme
approved these changes
Mar 3, 2021
There was a problem hiding this comment.
Tested using SACLA-MPCCD-Phase3-21528-5images.h5 after running dials.import and dials.find_spots. Behaviour looks correct and visualises already existing code (nearest neighbours), so more tests aren't needed. Definitely a helpful change. Looks like build errors are just from the master/main change.
|
Yes, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To aid orientation and reflection matching between the reciprocal lattice and image viewers, this change introduces optional labelling for the reciprocal lattice point nearest the view centre.
