Improve stability of error model determination in dials.scale. #1649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an extra filtering step to remove symmetry groups with abnormally
high internal variance, which helps stabilise the error model minimisation.
This was causing an issue with some less-than-great datasets, where the error model
parameters were not successfully determined, and is fixed with this change. This change
has minimal effect on good datasets as very few groups are typically filtered out.