-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-enable Azure Windows builds #1652
Conversation
and a newsfragment
by not running with ancient compilers
Codecov Report
@@ Coverage Diff @@
## main #1652 +/- ##
==========================================
+ Coverage 66.65% 66.66% +0.01%
==========================================
Files 616 616
Lines 68983 69013 +30
Branches 9598 9603 +5
==========================================
+ Hits 45981 46008 +27
- Misses 21066 21069 +3
Partials 1936 1936 |
So the runtime is now on the same order of magnitude as linux and mac builds, so in principle this can be merged. Might want to look into that failing pickle test though. (Appreciate this is the aim of #1651) |
And we should probably document somewhere that Python 3.6 is not supported on Windows |
Sounds good. I'm happy to write a "Building DIALS on Windows" webpage. I suppose we are still some way off providing installable builds. We should also clearly document that Windows support is still limited, due to lack of multiprocessing. That's something I want to look into, but I think it's going to be a case of making everything I look at pickleable, which is going to be quite some work. |
To be honest we can document the lack of support in the code quite easily... |
They will be horribly slow until we stop building cbflib