Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable Azure Windows builds #1652

Merged
merged 6 commits into from
Apr 15, 2021
Merged

re-enable Azure Windows builds #1652

merged 6 commits into from
Apr 15, 2021

Conversation

Anthchirp
Copy link
Member

They will be horribly slow until we stop building cbflib

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #1652 (760f29b) into main (396ba98) will increase coverage by 0.01%.
The diff coverage is 89.47%.

❗ Current head 760f29b differs from pull request most recent head 53d3ae7. Consider uploading reports for the commit 53d3ae7 to get more accurate results

@@            Coverage Diff             @@
##             main    #1652      +/-   ##
==========================================
+ Coverage   66.65%   66.66%   +0.01%     
==========================================
  Files         616      616              
  Lines       68983    69013      +30     
  Branches     9598     9603       +5     
==========================================
+ Hits        45981    46008      +27     
- Misses      21066    21069       +3     
  Partials     1936     1936              

@Anthchirp
Copy link
Member Author

So the runtime is now on the same order of magnitude as linux and mac builds, so in principle this can be merged. Might want to look into that failing pickle test though. (Appreciate this is the aim of #1651)

@Anthchirp
Copy link
Member Author

And we should probably document somewhere that Python 3.6 is not supported on Windows

@dagewa
Copy link
Member

dagewa commented Apr 15, 2021

Sounds good. I'm happy to write a "Building DIALS on Windows" webpage. I suppose we are still some way off providing installable builds.

We should also clearly document that Windows support is still limited, due to lack of multiprocessing. That's something I want to look into, but I think it's going to be a case of making everything I look at pickleable, which is going to be quite some work.

@Anthchirp
Copy link
Member Author

To be honest we can document the lack of support in the code quite easily...

@Anthchirp Anthchirp merged commit e5213f4 into main Apr 15, 2021
@Anthchirp Anthchirp deleted the windows branch April 15, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants