Fix crash in dials.scale when no reflections remain after initial filtering #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filtering. This was due to an uncaught 'BadDatasetForScalingException'
jbeilstenedmands
force-pushed
the
scaling_error_handling_bug
branch
from
958a8bb
to
3ed485e
Compare
Codecov Report
@@ Coverage Diff @@
## main #1654 +/- ##
==========================================
+ Coverage 66.66% 66.69% +0.02%
==========================================
Files 616 616
Lines 69013 69040 +27
Branches 9603 9606 +3
==========================================
+ Hits 46008 46044 +36
+ Misses 21069 21061 -8
+ Partials 1936 1935 -1 |
ndevenish
pushed a commit
that referenced
this pull request
Apr 15, 2021
…tering (#1654) This was due to an uncaught 'BadDatasetForScalingException'
Merged
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Apr 15, 2021
Bugfixes -------- - ``dials.scale``: Fix crash when full-matrix minimisation is unsuccessful due to indeterminate normal equations. (#1653) - ``dials.scale``: Fix crash when no reflections remain after initial filtering. (#1654) - ``dials.export``: Fix error observed with ``format=mmcif`` for narrow sweeps with low symmetry (#1656)
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Apr 16, 2021
Bugfixes -------- - ``dials.scale``: Fix crash when full-matrix minimisation is unsuccessful due to indeterminate normal equations. (#1653) - ``dials.scale``: Fix crash when no reflections remain after initial filtering. (#1654) - ``dials.export``: Fix error observed with ``format=mmcif`` for narrow sweeps with low symmetry (#1656)
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Apr 17, 2021
Bugfixes -------- - ``dials.scale``: Fix crash when full-matrix minimisation is unsuccessful due to indeterminate normal equations. (#1653) - ``dials.scale``: Fix crash when no reflections remain after initial filtering. (#1654) - ``dials.export``: Fix error observed with ``format=mmcif`` for narrow sweeps with low symmetry (#1656)
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Apr 18, 2021
Bugfixes -------- - ``dials.scale``: Fix crash when full-matrix minimisation is unsuccessful due to indeterminate normal equations. (#1653) - ``dials.scale``: Fix crash when no reflections remain after initial filtering. (#1654) - ``dials.export``: Fix error observed with ``format=mmcif`` for narrow sweeps with low symmetry (#1656)
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Apr 19, 2021
Bugfixes -------- - ``dials.scale``: Fix crash when full-matrix minimisation is unsuccessful due to indeterminate normal equations. (#1653) - ``dials.scale``: Fix crash when no reflections remain after initial filtering. (#1654) - ``dials.export``: Fix error observed with ``format=mmcif`` for narrow sweeps with low symmetry (#1656)
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Apr 19, 2021
Bugfixes -------- - ``dials.scale``: Fix crash when full-matrix minimisation is unsuccessful due to indeterminate normal equations. (#1653) - ``dials.scale``: Fix crash when no reflections remain after initial filtering. (#1654) - ``dials.export``: Fix error observed with ``format=mmcif`` for narrow sweeps with low symmetry (#1656) - Fix image numbering inconsistency in ascii histogram of per-image spot counts (#1660)
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Apr 19, 2021
Bugfixes -------- - ``dials.scale``: Fix crash when full-matrix minimisation is unsuccessful due to indeterminate normal equations. (#1653) - ``dials.scale``: Fix crash when no reflections remain after initial filtering. (#1654) - ``dials.export``: Fix error observed with ``format=mmcif`` for narrow sweeps with low symmetry (#1656) - Fix image numbering inconsistency in ascii histogram of per-image spot counts (#1660) - ``dials.find_spots_server``: Significant performance improvement for HDF5 grid scans. (#1665)
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Apr 20, 2021
Bugfixes -------- - ``dials.scale``: Fix crash when full-matrix minimisation is unsuccessful due to indeterminate normal equations. (#1653) - ``dials.scale``: Fix crash when no reflections remain after initial filtering. (#1654) - ``dials.export``: Fix error observed with ``format=mmcif`` for narrow sweeps with low symmetry (#1656) - Fix image numbering inconsistency in ascii histogram of per-image spot counts (#1660) - ``dials.find_spots_server``: Significant performance improvement for HDF5 grid scans. (#1665)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be caused in edge cases where there are no good reflections left, and was due to an uncaught
BadDatasetForScalingException. This is now correctly caught and the dataset excluded as originally intended.Requires #1653 to be merged first as the new test in this PR also triggers that separate bug.