Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially fix cosym documentation build #1675

Merged
merged 2 commits into from
Apr 24, 2021
Merged

Conversation

ndevenish
Copy link
Member

The merging of #1647 removed a module previously referenced by the documentation. That is fixed here.

Also a problem, however is this section in the dials.cosym documentation:

image

This output has now been removed, so requires reconsideration.

@ndevenish ndevenish requested a review from rjgildea April 24, 2021 13:09
@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #1675 (2ca4453) into main (f865f61) will not change coverage.
The diff coverage is n/a.

❗ Current head 2ca4453 differs from pull request most recent head 9ab5b1a. Consider uploading reports for the commit 9ab5b1a to get more accurate results

@@           Coverage Diff           @@
##             main    #1675   +/-   ##
=======================================
  Coverage   66.65%   66.65%           
=======================================
  Files         615      615           
  Lines       68868    68868           
  Branches     9571     9571           
=======================================
  Hits        45903    45903           
  Misses      21040    21040           
  Partials     1925     1925           

@Anthchirp
Copy link
Member

build failure unrelated and fixed on main

@Anthchirp Anthchirp merged commit 8b95a34 into dials:main Apr 24, 2021
@ndevenish ndevenish deleted the fix_cosym_docs branch February 24, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants