Faster resolution filtering in find_spots server #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid overhead of calculating per-pixel resolution masks in spotfinding and instead perform post-filtering of spot centroids by resolution. This save ~2 seconds the first time a process sees an image from an EIGER 16M dataset. See also #1587
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid overhead of calculating per-pixel resolution masks in spotfinding and instead perform post-filtering of spot centroids by resolution. This save ~2 seconds the first time a process sees an image from an EIGER 16M dataset. When the number of per-image analysis instances is of comparable order of magnitude to the number of images, can provide a significant time saving.
See also #1587
time.perf_counter()instead oftime.time()