Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Sphinx to <4 to fix documentation build #1696

Merged
merged 2 commits into from
May 10, 2021

Conversation

ndevenish
Copy link
Member

The brand new release doesn't work with parts of the documentation build. This fixes the version to remain on 3.x, so the documentation builds again.

The new release doesn't work with parts of the cctbx documentation build
@ndevenish ndevenish requested a review from Anthchirp May 10, 2021 19:28
Copy link
Member

@Anthchirp Anthchirp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Any indication how much work upgrading to v4 involves?

@ndevenish
Copy link
Member Author

I stopped digging too hard at ValueError: no signature found for builtin <Boost.Python.function object at 0x563236aca370>. I got a completely different set of errors on the mac/linux machines I tried to reproduce on, so went to just patch this.

@ndevenish ndevenish merged commit e823b44 into dials:main May 10, 2021
@ndevenish ndevenish deleted the sphinx_limit branch February 24, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants