-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run xfel-regression on Azure #1707
Conversation
For whatever reason this leads to the stage outcome to not be set to 'success' although the job outcome is shown as successful either way. This is probably an Azure bug, but given my experience with more complicated issues (ie. the broken cache issue) it's not worth reporting as it won't get beyond first level support.
New issue after this is merged: This dials test is not run during as part of the main tests, as
It is also not run as part of the PR builds where I would suggest that either the test is moved into |
for a slightly nicer display on the GitHub summary page
This is now ready for review. xfel-regression tests are run after the DIALS tests passed, and in PR builds only. The output is aggregated and reported in a separate build job. I also added another PR job stage ("Summary: Ready to merge") that summarizes the cross-platform dials tests without the xfel-regression tests. I note that the xfel-regression tests currently fail on MacOS, I'm not sure whether they are supposed to, or not. We can disable the xfel-regression test on MacOS for now and address this in a separate issue/PR. |
Thanks! This is great, appreciate the effort. The failure on macos is the cosym test which uses MPI (It does pass on linux). The cctbx_project macos Azure XFEL CI pipeline skips the test as it doesn't install mpi4py. I've essentially never done MPI stuff on macos, so I'd say it's safe to skip that test on macos. The rest of the tests pass on macos so I'll just add a macos check to the run_tests.py in xfel_regression. I'll work on |
Ok, cosym test updated to only run on linux. Ready to re-run the tests, but I'm not sure if I have the access to do so. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Glad to hear! (The easiest way to force a rerun of the PR build only is to just close and reopen the pull request.) |
Gotcha thanks. Looks like a clean build! |
kapton stuff -> #1712, will merge this here |
Adds the xfel-regression test pipeline laid out in #1671 to pull request builds only, and in such a way as to
At this time this is work in progress, especially to test out the pull-request build behaviour, but on merging will also close #1671.