Deprecate preserve_exception_message in dials.util.mp
#1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graeme-winter
approved these changes
May 24, 2021
| @@ -53,7 +54,7 @@ def parallel_map( | |||
| asynchronous=True, | |||
| callback=None, | |||
| preserve_order=True, | |||
| preserve_exception_message=True, | |||
| preserve_exception_message=..., | |||
| @@ -63,6 +64,13 @@ def parallel_map( | |||
| """ | |||
| from dials.util.cluster_map import cluster_map as drmaa_parallel_map | |||
|
|
|||
| if preserve_exception_message is not Ellipsis: | |||
There was a problem hiding this comment.
OK, this is a really nice use of a NIL value which is not truth-like.
| @@ -83,7 +91,7 @@ def parallel_map( | |||
| qsub_command=qsub_command, | |||
| asynchronous=asynchronous, | |||
| preserve_order=preserve_order, | |||
| preserve_exception_message=preserve_exception_message, | |||
| preserve_exception_message=True, | |||
There was a problem hiding this comment.
Shouldn't it be removed from drmaa_parallel_map while we're there?
Codecov Report
@@ Coverage Diff @@
## main #1722 +/- ##
==========================================
- Coverage 67.14% 67.13% -0.01%
==========================================
Files 615 615
Lines 69053 69059 +6
Branches 9616 9619 +3
==========================================
- Hits 46365 46364 -1
- Misses 20756 20760 +4
- Partials 1932 1935 +3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe there exists no sensible scenario in which this would be set to
False.