Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numbers! #1751

Merged
merged 3 commits into from
Jun 23, 2021
Merged

Numbers! #1751

merged 3 commits into from
Jun 23, 2021

Conversation

dagewa
Copy link
Member

@dagewa dagewa commented Jun 17, 2021

Excessive precision spotted while reading https://github.com/graeme-winter/dials_tutorials/blob/main/br-lyso-multi/multicrystal.md

BTW don't end a branch name in !. It does slightly break GitHub ;-)

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #1751 (1a7ae2c) into main (bb55599) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 1a7ae2c differs from pull request most recent head 8e9eeaf. Consider uploading reports for the commit 8e9eeaf to get more accurate results

@@           Coverage Diff           @@
##             main    #1751   +/-   ##
=======================================
  Coverage   67.22%   67.22%           
=======================================
  Files         616      616           
  Lines       69014    69014           
  Branches     9617     9617           
=======================================
  Hits        46392    46392           
  Misses      20680    20680           
  Partials     1942     1942           

@dagewa
Copy link
Member Author

dagewa commented Jun 23, 2021

@ndevenish you had suggestions regarding this?

@ndevenish ndevenish merged commit a3a2aaa into main Jun 23, 2021
@ndevenish ndevenish deleted the numbers! branch June 23, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants