Preserve imageset_id information, and unindexed reflections, in dials.combine_experiments #1760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
"imageset_id"
column of the reflection table became meaningless afterdials.combine_experiments
because the mapping between imageset and reflection was lost for unindexed reflections. In addition,dials.image_viewer
anddials.reciprocal_lattice_viewer
relied on this mapping for indexed reflections, leading to #1093.This change preserves the mapping by working out what the old and new indexes were, and rewrites the reflections. Because this mapping is preserved, unindexed reflections can now be carried over to the combined file.
I've also rewritten the test to use the
l_cysteine_dials_output
test output instead ofvmxi_proteinase_k_sweeps
, because the latter does not include unindexed reflections.Partially #1093 fix.
dials.scale
probably also requires separate attention.