-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit checks for python comprehensions #1764
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1764 +/- ##
=======================================
Coverage 67.22% 67.23%
=======================================
Files 616 616
Lines 69021 69012 -9
Branches 9618 9609 -9
=======================================
Hits 46399 46399
+ Misses 20680 20671 -9
Partials 1942 1942 |
- repo: https://github.com/PyCQA/isort.git | ||
rev: 5.5.3 | ||
- repo: https://github.com/PyCQA/isort | ||
rev: 5.6.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a reason this was updated also, or just an opportunity to update? Why to 5.6.4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an upportunity update to the most recent version that supports pre-commit <2.9, and that is also already referenced in other repositories such as ISPyB, zocalo, workflows, dlstbx, ...
I've also gone through and updated the rest of the places where this warns. It looks like a good check. I also approve of consolidating configurations. |
- Single-source flake8 configuration - Enable 'F541 f-string is missing placeholders' check - Fix flake8 C4 errors left over from #1764
This will now flag code such as
which have been fixed in this pull request.
Around 25 more remain.