Text overlay colours #1781
Merged
Text overlay colours #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set this to work for resolution rings, Miller indices and basis vector labels. Also make the colours just off white and black for better visibility, as the pixels often have these extreme colours
Codecov Report
@@ Coverage Diff @@
## main #1781 +/- ##
==========================================
+ Coverage 67.23% 67.29% +0.06%
==========================================
Files 616 616
Lines 69014 69270 +256
Branches 9619 9675 +56
==========================================
+ Hits 46399 46617 +218
- Misses 20671 20705 +34
- Partials 1944 1948 +4 |
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resolution rings and Miller index text overlays switched between white and black to provide contrast with the image, but the basis vector labels were always black. Fix that by providing a function to choose a suitable text colour and use that in each place.
Also, change to light vs dark grey rather than white vs black. The extremes (white and black) are common for pixels in diffraction images where the contrast is tuned to a narrow part of the full dynamic range. Better to choose a colour that is still visible even against a solid white or black background.