Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix windows build by calling libtbx pytest explicitly #1791

Merged
merged 2 commits into from
Jul 6, 2021

Conversation

ndevenish
Copy link
Member

With cctbx/dxtbx@0cc3c65, the dxtbx dispatcher generation changed slightly. The old pytest override should have been preserved with this entry_point. For some reason this doesn't appear to be working for the windows PR build.

This works around the problem by calling libtbx.python explicitly, bypassing the need for an explicit pytest outer dispatcher. This is done in order to fix the builds now.

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #1791 (1a0276b) into main (8f21749) will not change coverage.
The diff coverage is n/a.

❗ Current head 1a0276b differs from pull request most recent head 13f9f4c. Consider uploading reports for the commit 13f9f4c to get more accurate results

@@           Coverage Diff           @@
##             main    #1791   +/-   ##
=======================================
  Coverage   67.12%   67.12%           
=======================================
  Files         617      617           
  Lines       69326    69326           
  Branches     9647     9647           
=======================================
  Hits        46532    46532           
  Misses      20848    20848           
  Partials     1946     1946           

@ndevenish ndevenish enabled auto-merge (squash) July 6, 2021 11:07
@ndevenish ndevenish merged commit 656014e into main Jul 6, 2021
@ndevenish ndevenish deleted the fix_windows branch July 6, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants