Always enable absorption correction if absorption_level parameter set in dials.scale #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el parameter set. The auto model rules mean that the physical-model absorption correction is turned off if the scan oscillation range is < 60 degrees. Now, if the absorption_level parameter is set, the absorption correction is enabled for all scan oscillation sizes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto model rules mean that the physical-model absorption correction is turned off if the scan oscillation range is < 60 degrees. Now, if the
absorption_levelparameter is set, the absorption correction is enabled for all scan oscillation sizes.This is a slight behaviour change which I believe makes the program behave more as a user would expect.