Fix a compiler warning. #1806
Merged
Fix a compiler warning. #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catching a polymorphic type by value raises gcc 8.3.0 warning. Use catch(thing const&) instead.
Codecov Report
@@ Coverage Diff @@
## main #1806 +/- ##
=======================================
Coverage 67.11% 67.11%
=======================================
Files 617 617
Lines 69360 69360
Branches 9647 9647
=======================================
Hits 46549 46549
Misses 20867 20867
Partials 1944 1944 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catching a polymorphic type by value raises gcc 8.3.0 warning.
Use catch(thing const&) instead.