Fix incorrect output files in dials.scale targeted scaling if >1 target sweep #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1815 +/- ##
=======================================
Coverage 67.13% 67.13%
=======================================
Files 617 617
Lines 69406 69412 +6
Branches 9654 9654
=======================================
+ Hits 46594 46600 +6
Misses 20870 20870
Partials 1942 1942 |
ndevenish
pushed a commit
that referenced
this pull request
Jul 26, 2021
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Jul 26, 2021
Bugfixes -------- - ``dials.stills_process``: Fix case where imagesets and experiment filenames could potentially disagree (#1814) - ``dials.scale``: Fix incorrect output files, for targeted scaling with more than one target dataset. (#1815) - ``dials.image_viewer``: Fix opening datasets with ``load_models=False`` (#1818)
Merged
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Jul 27, 2021
Bugfixes -------- - ``dials.stills_process``: Fix case where imagesets and experiment filenames could potentially disagree (#1814) - ``dials.scale``: Fix incorrect output files, for targeted scaling with more than one target dataset. (#1815) - ``dials.image_viewer``: Fix opening datasets with ``load_models=False`` (#1818)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix corner case where incorrect datasets were saved as output for targeted scaling.