Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit hooks #1816

Merged
merged 5 commits into from
Jul 26, 2021
Merged

Update pre-commit hooks #1816

merged 5 commits into from
Jul 26, 2021

Conversation

ndevenish
Copy link
Member

Same as cctbx/dxtbx#403, mainly to get the new pre-commit-hook branch defaults changes. This will go back to "Disallow commit on main".

Rough guide to changes between these version:

  • Isort: Mainly stability and configuration changes
  • Black: Mainly internal restructuring, string and docstring edge-case handling
  • flake8: Updated backend checkers
  • pre-commit-hooks (things that affect us):
    • no-commit-to-branch: added "main" to default blocked branches <- the thing I wanted
    • check-added-large-files: added an --enforce-all option to check files already existing

Additionally, check-yaml fell over on .clang-format. We never ran this before because it hasn't been changed since we added the validation check. This needs you to explicitly request multi-document yamls, which has been added.

There are a few rogue flake8 issues with pre-commit run --all, but I have not changed them here.

@ndevenish ndevenish merged commit b48cb30 into dials:main Jul 26, 2021
@ndevenish ndevenish deleted the precommit branch February 24, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants