Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dials.refine_bravais_settings: correctly report mI settings #1825

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Conversation

rjgildea
Copy link
Contributor

@rjgildea rjgildea commented Jul 30, 2021

Whilst the correct unit cell was being output for I2 settings, the output incorrectly reported this as mC, potentially causing confusion.

Before:

$ dials.refine_bravais_settings indexed.{expt,refl}
...
Chiral space groups corresponding to each Bravais lattice:
aP: P1
mC: C2
+------------+--------------+--------+--------------+----------+-----------+------------------------------------------+----------+---------------+
|   Solution |   Metric fit |   rmsd | min/max cc   |   #spots | lattice   | unit_cell                                |   volume | cb_op         |
|------------+--------------+--------+--------------+----------+-----------+------------------------------------------+----------+---------------|
|   *      2 |       0.0252 |  0.112 | 0.743/0.743  |    18270 | mC        | 44.39  53.14 111.61  90.00  99.76  90.00 |   259466 | a,-b,-a-b-2*c |
|   *      1 |       0      |  0.111 | -/-          |    18292 | aP        | 44.41  53.16  62.42 115.23 101.78  89.99 |   129876 | a,b,c         |
+------------+--------------+--------+--------------+----------+-----------+------------------------------------------+----------+---------------+
* = recommended solution

This PR:

$ dials.refine_bravais_settings indexed.{expt,refl}
...
Chiral space groups corresponding to each Bravais lattice:
aP: P1
mI: I2
+------------+--------------+--------+--------------+----------+-----------+------------------------------------------+----------+---------------+
|   Solution |   Metric fit |   rmsd | min/max cc   |   #spots | lattice   | unit_cell                                |   volume | cb_op         |
|------------+--------------+--------+--------------+----------+-----------+------------------------------------------+----------+---------------|
|   *      2 |       0.0252 |  0.112 | 0.743/0.743  |    18270 | mI        | 44.39  53.14 111.61  90.00  99.76  90.00 |   259466 | a,-b,-a-b-2*c |
|   *      1 |       0      |  0.111 | -/-          |    18292 | aP        | 44.41  53.16  62.42 115.23 101.78  89.99 |   129876 | a,b,c         |
+------------+--------------+--------+--------------+----------+-----------+------------------------------------------+----------+---------------+
* = recommended solution

Whilst the correct cell was being output for I2 settings, the output
incorrectly reported this as mC, potentially causing confusion.
@rjgildea rjgildea requested a review from dagewa July 30, 2021 14:16
Copy link
Member

@dagewa dagewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can confirm this works on the Mpro tutorial

Chiral space groups corresponding to each Bravais lattice:
aP: P1
mI: I2
+------------+--------------+--------+--------------+----------+-----------+------------------------------------------+----------+---------------+
|   Solution |   Metric fit |   rmsd | min/max cc   |   #spots | lattice   | unit_cell                                |   volume | cb_op         |
|------------+--------------+--------+--------------+----------+-----------+------------------------------------------+----------+---------------|
|   *      2 |       0.0252 |  0.112 | 0.743/0.743  |    18270 | mI        | 44.39  53.14 111.61  90.00  99.76  90.00 |   259466 | a,-b,-a-b-2*c |
|   *      1 |       0      |  0.111 | -/-          |    18292 | aP        | 44.41  53.16  62.42 115.23 101.78  89.99 |   129876 | a,b,c         |
+------------+--------------+--------+--------------+----------+-----------+------------------------------------------+----------+---------------+

@rjgildea rjgildea merged commit abaab4d into main Jul 30, 2021
@rjgildea rjgildea deleted the rbs-mC-mI branch July 30, 2021 16:50
@dagewa
Copy link
Member

dagewa commented Jul 31, 2021

I should have noted, this changes the behaviour for the Mpro tutorial a bit, so that text would need updating https://dials.github.io/documentation/tutorials/mpro_x0692.html

@dagewa dagewa mentioned this pull request Jul 31, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants