dials.find_spots: fix counting in histogram output

[rjgildea]

Fixes #1826

[graeme-winter]

I am looking at the diffs and I don't see how this fixes the problem, because I don't see how this is a problem. However I will look again in a mo once it is green and the tests are passed.

[rjgildea]

Using:

$ dials.import $(dials.data get -q fumarase)/*.img
$ dials.find_spots imported.expt

On main:

Histogram of per-image spot count for imageset 1:
35258 spots found on 60 images (max 1047 / bin)
*                                                           
*                                                           
*                                                          *
*                                                          *
************** ****** * *** *** ***  ******          *     *
************** ***************************** ************* *
******************************************** ***************
************************************************************
************************************************************
************************************************************
1                          image                          60

Histogram of per-image spot count for imageset 1:
37328 spots found on 60 images (max 1102 / bin)
*                                                           
*                                                           
*                                                          *
*                            *                             *
************** * *************   **   * ***                *
************** ***************************** ***************
******************************************** ***************
************************************************************
************************************************************
************************************************************
1                          image                          60

With this PR:

Histogram of per-image spot count for imageset 0:
35258 spots found on 60 images (max 1047 / bin)
*                                                           
*                                                           
*                                                          *
*                                                          *
************** ****** * *** *** ***  ******          *     *
************** ***************************** ************* *
******************************************** ***************
************************************************************
************************************************************
************************************************************
1                          image                          60

Histogram of per-image spot count for imageset 1:
37328 spots found on 60 images (max 1102 / bin)
*                                                           
*                                                           
*                                                          *
*                            *                             *
************** * *************   **   * ***                *
************** ***************************** ***************
******************************************** ***************
************************************************************
************************************************************
************************************************************
1                          image                          60

[rjgildea]

I am looking at the diffs and I don't see how this fixes the problem, because I don't see how this is a problem. However I will look again in a mo once it is green and the tests are passed.

i was coming from the inner loop over all experiments, so it was always equal to the index of the last experiment in the list. It should have come from the outer loop over imagesets.

[graeme-winter]

Now I get it it is one of those trivial but valuable fixes - thank you! Such things are annoying when you find them 🙂

+10 pts and one issue closing card

[codecov]

Codecov Report

Merging #1827 (95d6433) into main (a827a65) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1827   +/-   ##
=======================================
  Coverage   67.13%   67.13%           
=======================================
  Files         617      617           
  Lines       69416    69416           
  Branches     9655     9655           
=======================================
  Hits        46601    46601           
  Misses      20873    20873           
  Partials     1942     1942