Report pixel coordinate in fast, slow order #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From slow, fast to fast, slow. The latter matches the conventional ordering of positions using X, Y, Z in other parts of DIALS
dagewa
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1849 +/- ##
=======================================
Coverage 67.16% 67.16%
=======================================
Files 619 619
Lines 70023 70023
Branches 9723 9723
=======================================
+ Hits 47031 47032 +1
Misses 21023 21023
+ Partials 1969 1968 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See details in cctbx/dxtbx#421. This PR changes the order the coordinate under the cursor is displayed in the image viewer. It also changes a test to use the
fast_slow_beam_centreparameter rather thanslow_fast_beam_centre