Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore simtbx to azure windows testing #1862

Merged
merged 3 commits into from
Aug 23, 2021
Merged

Restore simtbx to azure windows testing #1862

merged 3 commits into from
Aug 23, 2021

Conversation

phyy-nx
Copy link
Member

@phyy-nx phyy-nx commented Aug 23, 2021

This reverts commit ee7a9ef.

Windows build in simtbx was fixed by cctbx/cctbx_project#641, so this PR restores testing.

Newsfragments a bit weird here. I'll leave it up to @ndevenish to decide what do to.

@phyy-nx phyy-nx requested a review from ndevenish August 23, 2021 18:07
@ndevenish
Copy link
Member

Awesome, last time I checked the tests hadn't passed yet (and thus the dials repo updated). Thanks for sorting this.

@ndevenish ndevenish enabled auto-merge (squash) August 23, 2021 18:31
@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #1862 (f3964f4) into main (53b5a3f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1862   +/-   ##
=======================================
  Coverage   67.15%   67.15%           
=======================================
  Files         617      617           
  Lines       69539    69539           
  Branches     9673     9673           
=======================================
  Hits        46696    46696           
  Misses      20898    20898           
  Partials     1945     1945           

@ndevenish ndevenish merged commit 975cc91 into main Aug 23, 2021
@ndevenish ndevenish deleted the test_simtbx branch August 23, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants