Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default image viewer helper message to reflect current controls. #1869

Merged
merged 3 commits into from
Oct 1, 2021

Conversation

toastisme
Copy link
Contributor

This just updates the default image viewer helper message, as it seems to be out of date with current controls.

I can't find anywhere where the intensity plot is used (I'm guessing it's OnShowPlot), and the right click to zoom in wx_viewer doesn't seem to be in use.

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #1869 (8893825) into main (9aede7c) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1869      +/-   ##
==========================================
- Coverage   67.15%   67.05%   -0.11%     
==========================================
  Files         617      617              
  Lines       69532    70303     +771     
  Branches     9672     9886     +214     
==========================================
+ Hits        46697    47144     +447     
- Misses      20892    21217     +325     
+ Partials     1943     1942       -1     

Copy link
Contributor

@rjgildea rjgildea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are both of these actually required or (more likely) does one of them represent dead code. in which case it should probably be removed (not suggesting you should do that here in this PR)?

newsfragments/1869.misc Outdated Show resolved Hide resolved
Co-authored-by: Richard Gildea <rjgildea@users.noreply.github.com>
@toastisme
Copy link
Contributor Author

toastisme commented Oct 1, 2021

Are both of these actually required or (more likely) does one of them represent dead code. in which case it should probably be removed (not suggesting you should do that here in this PR)?

It looks like only frame.py is used, but felt it was best to at least keep rstbx_frame.py updated in case this is used in some other context.

@toastisme toastisme merged commit 0db95d6 into main Oct 1, 2021
@toastisme toastisme deleted the update_image_viewer_helper_message branch October 1, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants