Allow fixing of scaling model corrections #1883
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain workflows would benefit from being able to fix particular scaling model corrections.
The use case in mind is to refine an absorption correction when scaling multiple sweeps from a crystal, then in subsequent scaling jobs when combining with other crystals, to be able to keep the individual absorption corrections without further refinement.
Or perhaps if one could determine an absorption correction empirically, then this can be fixed during scaling model minimisation.
Achieved with a phil parameter with the syntax
model.correction.fix=correction_name
e.g.physical.correction.fix=absorption
.