Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of files produced by dials.stills_process by default #1888

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

phyy-nx
Copy link
Member

@phyy-nx phyy-nx commented Sep 23, 2021

  • Switch composite_output to True by default
  • Supress the production of imported files and strong.refl files
  • Make adjustments to tests to test both composite_output True and False

Affects cctbx.xfel.plot_run_stats_from_experiments but not the xfel gui itself

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #1888 (2b26a81) into main (a9b4074) will increase coverage by 0.39%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##             main    #1888      +/-   ##
==========================================
+ Coverage   67.18%   67.58%   +0.39%     
==========================================
  Files         619      619              
  Lines       69933    70983    +1050     
  Branches     9710     9987     +277     
==========================================
+ Hits        46985    47971     +986     
- Misses      20983    21026      +43     
- Partials     1965     1986      +21     

phyy-nx and others added 2 commits October 6, 2021 14:03
- Switch composite_output to True by default
- Supress the production of imported files and strong.refl files
- Make adjustments to tests to test both composite_output True and False

Affects cctbx.xfel.plot_run_stats_from_experiments but not the xfel gui itself
@phyy-nx phyy-nx merged commit d60edfd into main Oct 7, 2021
@phyy-nx phyy-nx deleted the dsp_composite_output branch October 7, 2021 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants