Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of bad input for targeted scaling in dials.scale #1891

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

jbeilstenedmands
Copy link
Contributor

Catch errors in several places if unable to extract suitable data from target mtz/cif input files.

Thanks to @jmp1985 for reporting.

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #1891 (fa7e087) into main (78d8ed9) will decrease coverage by 0.00%.
The diff coverage is 9.09%.

@@            Coverage Diff             @@
##             main    #1891      +/-   ##
==========================================
- Coverage   67.19%   67.18%   -0.01%     
==========================================
  Files         619      619              
  Lines       69924    69933       +9     
  Branches     9708     9710       +2     
==========================================
+ Hits        46984    46985       +1     
- Misses      20977    20983       +6     
- Partials     1963     1965       +2     

@jbeilstenedmands jbeilstenedmands merged commit a9b4074 into main Oct 4, 2021
@jbeilstenedmands jbeilstenedmands deleted the target_scaling_error_handling branch October 4, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants