Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small molecule tutorial refresh #1900

Merged
merged 4 commits into from
Jan 17, 2022
Merged

Small molecule tutorial refresh #1900

merged 4 commits into from
Jan 17, 2022

Conversation

graeme-winter
Copy link
Contributor

Fixes #1897

@codecov
Copy link

codecov bot commented Oct 19, 2021 •
edited

Codecov Report

Merging #1900 (30036c8) into main (63eaaa8) will not change coverage.
The diff coverage is n/a.

❗ Current head 30036c8 differs from pull request most recent head 0c8b16f. Consider uploading reports for the commit 0c8b16f to get more accurate results

@@           Coverage Diff           @@
##             main    #1900   +/-   ##
=======================================
  Coverage   67.16%   67.16%           
=======================================
  Files         619      619           
  Lines       70023    70023           
  Branches     9723     9723           
=======================================
  Hits        47031    47031           
  Misses      21023    21023           
  Partials     1969     1969

@graeme-winter graeme-winter marked this pull request as ready for review November 2, 2021 13:05
@graeme-winter graeme-winter changed the title WIP: start tutorial refresh Small molecule tutorial refresh Nov 2, 2021
elena-pascal
elena-pascal approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@elena-pascal elena-pascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the addition of explanatory text in the lower half ✨

doc/sphinx/documentation/tutorials/small_molecule_tutorial.rst Outdated Show resolved Hide resolved
doc/sphinx/documentation/tutorials/small_molecule_tutorial.rst Outdated Show resolved Hide resolved
doc/sphinx/documentation/tutorials/small_molecule_tutorial.rst Outdated Show resolved Hide resolved
doc/sphinx/documentation/tutorials/small_molecule_tutorial.rst Outdated Show resolved Hide resolved
doc/sphinx/documentation/tutorials/small_molecule_tutorial.rst Outdated Show resolved Hide resolved
doc/sphinx/documentation/tutorials/small_molecule_tutorial.rst Show resolved Hide resolved
@ndevenish ndevenish merged commit f3c29b4 into main Jan 17, 2022
@ndevenish ndevenish deleted the update-small-tutorial branch January 17, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huwjenkins huwjenkins huwjenkins left review comments

@jbeilstenedmands jbeilstenedmands jbeilstenedmands left review comments

@elena-pascal elena-pascal elena-pascal approved these changes

@benjaminhwilliams benjaminhwilliams Awaiting requested review from benjaminhwilliams

@dagewa dagewa Awaiting requested review from dagewa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small molecule tutorial should include dials.scale
5 participants
@graeme-winter @huwjenkins @elena-pascal @jbeilstenedmands @ndevenish