Reword a docstring slightly #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1907 +/- ##
=======================================
Coverage 67.10% 67.10%
=======================================
Files 619 619
Lines 70002 70002
Branches 9732 9732
=======================================
Hits 46977 46977
Misses 21059 21059
Partials 1966 1966 |
ndevenish
force-pushed
the
docstring-change
branch
from
ceac07c
to
5a1b641
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like I never acted on cctbx/dxtbx#128, but instead dumped my knowledge of the DXTBX goniometer rotation operator convention in
dials.command_line.anvil_correction.goniometer_rotation.__doc__. Here's a small edit to that docstring to make it more readable.