Check unique space group on MTZ export #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1915 +/- ##
==========================================
- Coverage 67.11% 67.11% -0.01%
==========================================
Files 619 619
Lines 70012 70015 +3
Branches 9733 9734 +1
==========================================
Hits 46992 46992
- Misses 21053 21055 +2
- Partials 1967 1968 +1 |
rjgildea
approved these changes
Nov 16, 2021
Co-authored-by: Richard Gildea <rjgildea@users.noreply.github.com>
ndevenish
pushed a commit
that referenced
this pull request
Nov 17, 2021
Co-authored-by: Richard Gildea <rjgildea@users.noreply.github.com>
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Nov 17, 2021
Bugfixes -------- - ``dials.export``: No longer allow (erroneous) MTZ export for multiple experiments with multiple space groups. (#1915) - ``dials.export``: No longer fails for XDS_ASCII and SADABS export with ``intensity=auto``. (#1926) - ``dials.report``: Fix broken json output option. Include more graphs in json output. (#1932)
Merged
dagewa
added a commit
to dagewa/dials
that referenced
this pull request
Dec 13, 2021
Co-authored-by: Richard Gildea <rjgildea@users.noreply.github.com>
dagewa
added a commit
to dagewa/dials
that referenced
this pull request
Dec 13, 2021
Co-authored-by: Richard Gildea <rjgildea@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was possible to write an MTZ from multi-experiment DIALS files where the space group differs. Ensure this is illegal.