Document the DXTBX rotation operator convention #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1917 +/- ##
=======================================
Coverage 67.11% 67.11%
=======================================
Files 619 619
Lines 70012 70012
Branches 9733 9733
=======================================
Hits 46992 46992
Misses 21053 21053
Partials 1967 1967 |
|
This has informal 👍 offline from @elena-pascal & @dagewa. |
dagewa
pushed a commit
to dagewa/dials
that referenced
this pull request
Dec 13, 2021
DXTBX uses an in-house convention for the representation of the goniostat rotation operator R. Here, add documentation of that convention to the conventions.rst page of the docs. Closes cctbx/dxtbx#128.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DXTBX uses an in-house convention for the representation of the goniostat rotation operator R. Here, I've added documentation of that convention to the
conventions.rstpage of the docs.Questions for reviewers:
Partial fix for cctbx/dxtbx#128.