Specifying intensity_choice=auto fails for some dials.export output formats #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ified in options to dials.export
jbeilstenedmands
approved these changes
Nov 15, 2021
|
The CI tests seem to be an unrelated issue. Merging now to put into release. Thanks for this. |
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Nov 16, 2021
Bugfixes -------- - ``dials.export``: No longer fails for XDS_ASCII and SADABS export with ``intensity=auto``. (#1926)
Merged
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Nov 17, 2021
Bugfixes -------- - ``dials.export``: No longer fails for XDS_ASCII and SADABS export with ``intensity=auto``. (#1926)
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Nov 17, 2021
Bugfixes -------- - ``dials.export``: No longer allow (erroneous) MTZ export for multiple experiments with multiple space groups. (#1915) - ``dials.export``: No longer fails for XDS_ASCII and SADABS export with ``intensity=auto``. (#1926) - ``dials.report``: Fix broken json output option. Include more graphs in json output. (#1932)
dagewa
pushed a commit
to dagewa/dials
that referenced
this pull request
Dec 13, 2021
…als#1926) Fix for format=xds_ascii or format=sadabs when intensity=auto is specified in options to dials.export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the output formats for
dials.exportfail whenintensity_choice=autois specified on the command line with the cryptic error:This change fixes that.