Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dials.report: fix json output #1932

Merged
merged 5 commits into from
Nov 17, 2021
Merged

dials.report: fix json output #1932

merged 5 commits into from
Nov 17, 2021

Conversation

rjgildea
Copy link
Contributor

  • Include more plots in json output
  • dials.data(..., pathlib=True)

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #1932 (a0bf920) into main (0609b93) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1932      +/-   ##
==========================================
+ Coverage   67.11%   67.13%   +0.01%     
==========================================
  Files         619      619              
  Lines       70012    70026      +14     
  Branches     9733     9733              
==========================================
+ Hits        46992    47011      +19     
+ Misses      21053    21049       -4     
+ Partials     1967     1966       -1     

@rjgildea rjgildea merged commit 75742c5 into main Nov 17, 2021
@rjgildea rjgildea deleted the report-json branch November 17, 2021 10:19
ndevenish pushed a commit that referenced this pull request Nov 17, 2021
* Include more plots in json output
* dials.data(..., pathlib=True)
DiamondLightSource-build-server added a commit that referenced this pull request Nov 17, 2021
Bugfixes
--------

- ``dials.export``: No longer allow (erroneous) MTZ export for multiple experiments with multiple space groups. (#1915)
- ``dials.export``: No longer fails for XDS_ASCII and SADABS export with ``intensity=auto``. (#1926)
- ``dials.report``: Fix broken json output option. Include more graphs in json output. (#1932)
dagewa pushed a commit to dagewa/dials that referenced this pull request Dec 13, 2021
* Include more plots in json output
* dials.data(..., pathlib=True)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants