Dockerfile and image build/push GitHub action #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For a tag e.g. v3.7.1 then parse out the branch name dials-3.7 to set as a build-arg to docker build * Trigger builds on pushes to main and new tags * Builds from main will be tagged :edge
Apparently the release branch bootstrap already knows to checkout the relevant release branches for all repos.
Codecov Report
@@ Coverage Diff @@
## main #1936 +/- ##
=======================================
Coverage 67.12% 67.12%
=======================================
Files 619 619
Lines 70029 70029
Branches 9734 9734
=======================================
Hits 47010 47010
Misses 21052 21052
Partials 1967 1967 |
I think this resulted in it trying to push the image dials/dials/dials instead of dials/dials
rjgildea
added a commit
that referenced
this pull request
Dec 2, 2021
Add a Dockerfile and "Build and push Docker images" GitHub action to build a docker image and push to the GitHub Container Registry and Docker Hub: - builds a new image on every push to main and tags it as ghcr.io/dials/dials:edge and docker.io/dials/dials:edge - builds a new image for every tag of the form vX.Y.Z and tags it as ghcr.io/dials/dials:X.Y.Z, ghcr.io/dials/dials:latest, docker.io/dials/dials:X.Y.Z and docker.io/dials/dials:latest
Closed
dagewa
pushed a commit
to dagewa/dials
that referenced
this pull request
Dec 13, 2021
Add a Dockerfile and "Build and push Docker images" GitHub action to build a docker image and push to the GitHub Container Registry and Docker Hub: - builds a new image on every push to main and tags it as ghcr.io/dials/dials:edge and docker.io/dials/dials:edge - builds a new image for every tag of the form vX.Y.Z and tags it as ghcr.io/dials/dials:X.Y.Z, ghcr.io/dials/dials:latest, docker.io/dials/dials:X.Y.Z and docker.io/dials/dials:latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Dockerfile and "Build and push Docker images" GitHub action to build a docker image and push to the GitHub Container Registry
This current implementation:
mainand tags it asghcr.io/dials/dials:edgevX.Y.Zand tags it asghcr.io/dials/dials:X.Y.Zandghcr.io/dials/dials:latestPossible additions or changes include building according to a schedule, e.g. for nightly builds, or adding tests to the image builds. We probably also want to push images to Docker Hub (as well, or instead of ghcr?), but I need to setup a Docker Hub Personal Access Token to enable this first.