Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FuncFormatter to convert ds2 to d-spacings #1953

Merged
merged 4 commits into from
Jan 14, 2022
Merged

Conversation

rjgildea
Copy link
Contributor

See also xia2/xia2#636

Copy link
Member

@benjaminhwilliams benjaminhwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, see inline comment below.

Also, I notice that fig and ax are defined early in dials.background but only used if params.output.plot is truthy. Should fig = ... and ax = ... be moved down to ~L117?
Please ignore, I wasn't reading it thoroughly enough.

command_line/background.py Outdated Show resolved Hide resolved
Co-authored-by: Ben Williams <benjaminhwilliams@users.noreply.github.com>
@rjgildea
Copy link
Contributor Author

Also, I notice that fig and ax are defined early in dials.background but only used if params.output.plot is truthy. Should fig = ... and ax = ... be moved down to ~L117?

I think this is because the plots are added to ax within a loop over imagesets - so if multiple imagesets are passed, then they all appear on the same plot.

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #1953 (1b6443b) into main (1eef873) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1953      +/-   ##
==========================================
- Coverage   67.15%   67.15%   -0.01%     
==========================================
  Files         620      621       +1     
  Lines       70129    70128       -1     
  Branches    10360    10357       -3     
==========================================
- Hits        47095    47094       -1     
  Misses      21063    21063              
  Partials     1971     1971              

@ndevenish ndevenish merged commit be8e6e6 into main Jan 14, 2022
@ndevenish ndevenish deleted the resolution_formatter branch January 14, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants