Handle d_max more gracefully #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graeme-winter
force-pushed
the
check-index-dmax
branch
from
95fad7e
to
8a7272e
Compare
Codecov Report
@@ Coverage Diff @@
## main #1957 +/- ##
==========================================
- Coverage 67.15% 67.15% -0.01%
==========================================
Files 620 620
Lines 70129 70131 +2
Branches 10360 10361 +1
==========================================
Hits 47095 47095
- Misses 21063 21065 +2
Partials 1971 1971 |
If d_max == 0 then do nothing, else additionally filter the selection. Fixes #1956
May debreak the builds
graeme-winter
force-pushed
the
check-index-dmax
branch
from
8a7272e
to
0bd33d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
params.d_minis set andd_max == 0then ignored_max, else additionally filter the selection. This restores expected behaviour.Fixes #1956