Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building against HDF5 1.12 #1973

Merged
merged 4 commits into from
Mar 28, 2022
Merged

Allow building against HDF5 1.12 #1973

merged 4 commits into from
Mar 28, 2022

Conversation

Anthchirp
Copy link
Member

HDF5 1.12 has been out for nearly two years (February 2020), so I think we can start looking into running on it and see what breaks.

I welcome comments of caution 😄

@graeme-winter
Copy link
Contributor

This absolutely needs trying out, to find out what the impact is. Will investigate.

@Anthchirp
Copy link
Member Author

merging in main, so that investigations would cover current numpy+hdf5 versions

to ensure we also run on current numpy and get most current versions of
all dependencies
@Anthchirp Anthchirp marked this pull request as ready for review March 22, 2022 13:20
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #1973 (ff55856) into main (e611c76) will not change coverage.
The diff coverage is n/a.

❗ Current head ff55856 differs from pull request most recent head 8db3ab3. Consider uploading reports for the commit 8db3ab3 to get more accurate results

@@           Coverage Diff           @@
##             main    #1973   +/-   ##
=======================================
  Coverage   68.34%   68.34%           
=======================================
  Files         654      654           
  Lines       76066    76066           
  Branches    10861    10861           
=======================================
  Hits        51987    51987           
  Misses      22051    22051           
  Partials     2028     2028           

@ndevenish
Copy link
Member

This will get better testing in the main repo, and in any case the conda-forge package appears to be using HDF5 1.12 already.

@ndevenish ndevenish merged commit 707412f into main Mar 28, 2022
@ndevenish ndevenish deleted the hdf5112 branch March 28, 2022 13:46
@ndevenish
Copy link
Member

Correction: I had thought this was the dxtbx CI, in which case the merge title would have been correct. I apologies for the somewhat confusing mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants