Allow reindexing using a multi-crystal reference dataset in dials.reindex #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indexing against multi-crystal data files
Codecov Report
@@ Coverage Diff @@
## main #1977 +/- ##
==========================================
+ Coverage 67.61% 67.64% +0.02%
==========================================
Files 629 629
Lines 71382 71409 +27
Branches 10472 10476 +4
==========================================
+ Hits 48263 48302 +39
+ Misses 21144 21127 -17
- Partials 1975 1980 +5 |
- Newsfragment - Remove old code line - Move scaling import to top area (since in command_line, there is an argument for doing this inline. However, there are plenty of other heavy-looking imports in there already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the necessary preprocessing to be able to use a multi-crystal dataset as a reference for reindexing.