Update pre-commit environments #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fast-fail on syntax errors * isort will maintain 'from future' imports * Update isort/black/flake8 versions
Codecov Report
@@ Coverage Diff @@
## main #1989 +/- ##
=======================================
Coverage 67.61% 67.61%
=======================================
Files 629 629
Lines 71428 71428
Branches 10481 10481
=======================================
Hits 48297 48297
Misses 21151 21151
Partials 1980 1980 |
Anthchirp
added a commit
that referenced
this pull request
Jan 25, 2022
This fixes a pre-commit vs. setuptools issue for new developer installs, and for existing installations when you run 'libtbx.precommit install'. Update 'future' imports throughout the code base, in preparation of upcoming pre-commit updates in #1989. Upgrade the Python version used in pytype pull request checks. Co-authored-by: Markus Gerstel <markus.gerstel@diamond.ac.uk>
and leave eg. minified JavaScript files alone
Anthchirp
force-pushed
the
pre-commit
branch
from
4f4abbe
to
0121931
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #1986