Change default colorscale from Jet to Viridis #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committer: Ammaar Saeed <ammsa23@gmail.com>
|
I second this. More about why rainbows are terrible: |
|
@ammsa23, thanks for the suggested changes, we'd like to get them merged. Are you happy to be added to the list of authors of the project, and to have us add attribution in the changelog (see my two recent commits on this branch)? |
|
Hi @benjaminhwilliams! Happy to be added to the list, and the changelogs look great to me! Thanks! |
|
Test failure will be addressed by dials/data#362 |
|
Yes, we're having a few build issues at the moment 😅 . We'll merge this in for DIALS 3.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it easier to compare data using a perceptually uniform sequential colormap/colorscale as opposed to a colorscale like Jet. Additionally, making this change increases accessibility of the software and the plots for the colorblind. Thanks for the consideration!