Remove gc.collect call in dials.scale #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2047 +/- ##
==========================================
- Coverage 68.48% 68.46% -0.02%
==========================================
Files 654 654
Lines 76521 76516 -5
Branches 10943 10943
==========================================
- Hits 52403 52386 -17
- Misses 22077 22088 +11
- Partials 2041 2042 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Housekeeping for a small section of the scaling code.
Garbage collection should be left to python to handle.
Some testing shows it's unlikely this was bringing much benefit, and definitely slows down the processing when processing 1000s of SSX images.
Rearrange some column deletion to earlier in the process to help with memory management.