dev.dials.ssx_index fixes #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2055 +/- ##
==========================================
- Coverage 68.42% 68.41% -0.01%
==========================================
Files 654 654
Lines 76531 76542 +11
Branches 10947 10951 +4
==========================================
+ Hits 52368 52370 +2
- Misses 22120 22126 +6
- Partials 2043 2046 +3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue in results reporting for h5 files (always reported that it had indexed 1 image).
Use
min_spotsparameter (default 10) to skip attempted indexing of weak/bad images.Correctly handle function calls when a total of 0 images get indexed.