dials.show without imageset #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, experiments created by dials.import_mtz are missing an imageset. Allow dials.show to display the experimental geometry by skipping the imageset parts.
Codecov Report
@@ Coverage Diff @@
## main #2056 +/- ##
=======================================
Coverage 80.08% 80.08%
=======================================
Files 576 576
Lines 65440 65439 -1
Branches 9232 9232
=======================================
+ Hits 52405 52406 +1
+ Misses 10998 10997 -1
+ Partials 2037 2036 -1 |
rjgildea
reviewed
Apr 5, 2022
Add comment to help remember this time...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dials.showwas crashing when passed an experiment list that had an empty imageset (for example, fromdials.import_mtz). In that case skip the display of format class and template.