Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning about throwing inside destructor #2083

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Fix warning about throwing inside destructor #2083

merged 2 commits into from
Apr 15, 2022

Conversation

ndevenish
Copy link
Member

Throwing an exception inside a destructor is by default a fatal error from C++. Just call terminate() directly instead.

@ndevenish ndevenish enabled auto-merge (squash) April 15, 2022 09:20
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #2083 (2c508b3) into main (6f40d26) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2083   +/-   ##
=======================================
  Coverage   68.48%   68.49%           
=======================================
  Files         654      654           
  Lines       76478    76478           
  Branches    10918    10918           
=======================================
+ Hits        52379    52383    +4     
+ Misses      22052    22050    -2     
+ Partials     2047     2045    -2     

@ndevenish ndevenish merged commit 0cda735 into main Apr 15, 2022
@ndevenish ndevenish deleted the no_throw_warn branch April 15, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants