Protect against mean=0 in simulation poisson distribution #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works on bootstrap builds, and prebuilt-cctbx linux, but depending on configuration at build time, could fail if boost is built with assertions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix against case in testing where a poisson distribution with zero mean could be generated. This works for bootstrap builds and conda-forge prebuilt cctbx on linux, but prebuilt on mac fails. Presumably this is sensitive to how boost was compiled - if boost assertions are enabled when scitbx is compiled, it can encounter this assert, killing the process.