Adjust test to avoid inconsistent results on windows for test_scale_and_filter.... #2104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1895
From the logs, the difference between Windows/Mac appears to start in the second round of scaling, in the first run of LBFGS minimisation. After around 30 steps, the RMSDs start changing in the 4th decimal place, so a slightly different solution is found, which causes the delta-cc-half scores of the two worst groups to change order and therefore the resultant dataset after filtering contains different sets of images, leading to large changes in Rpim etc.
Although this dataset is rather thin and radiation damaged, so the minimisation might be expected to be less stable, I have kept this as the test case and adjusted the test parameters to avoid relying on the behaviour past the point of divergence, while still testing the same overall functionality.