Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stills_process: crash on unhandled command line argument #2106

Merged
merged 3 commits into from
May 19, 2022
Merged

Conversation

dwpaley
Copy link
Contributor

@dwpaley dwpaley commented May 5, 2022

Currently if I type

$ dials.stills_process data.h5 params.phil abcd=efgh

or worse, one of:

$ dials.stills_process data.h5 params.phll
$ dials.stills_process data.h5 params.phil spotfinding.filter.d_max=10 # oops, should be spotfinder

the unhandled argument is ignored with possibly confusing consequences. Currently all unhandled arguments are assumed to be input paths. Can we validate that they are actually paths?

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #2106 (76f6ceb) into main (c645ecc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 76f6ceb differs from pull request most recent head 7401fc5. Consider uploading reports for the commit 7401fc5 to get more accurate results

@@           Coverage Diff           @@
##             main    #2106   +/-   ##
=======================================
  Coverage   80.36%   80.37%           
=======================================
  Files         580      580           
  Lines       65706    65708    +2     
  Branches     9260     9260           
=======================================
+ Hits        52805    52810    +5     
+ Misses      10847    10846    -1     
+ Partials     2054     2052    -2     

Co-authored-by: Nicholas Devenish <ndevenish@gmail.com>
@dwpaley dwpaley merged commit be6487c into main May 19, 2022
@dwpaley dwpaley deleted the raise_unhandled branch May 19, 2022 04:24
ndevenish added a commit that referenced this pull request May 30, 2022
Co-authored-by: Nicholas Devenish <ndevenish@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants