dials.image_viewer n_iqr fix #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interactive spot-finding in the image viewer.
|
@ndevenish 👀 for the news fragment. Otherwise this can be merged straight away. |
Codecov Report
@@ Coverage Diff @@
## main #2116 +/- ##
==========================================
- Coverage 80.39% 80.33% -0.06%
==========================================
Files 580 580
Lines 65807 66214 +407
Branches 9278 9467 +189
==========================================
+ Hits 52903 53193 +290
- Misses 10848 10919 +71
- Partials 2056 2102 +46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
n_iqrsetting forradial_profilethresholding appeared to do nothing when viewing images with "Threshold pixels" selected. It turns out this control was not actually connected to the algorithm. This fixes that.