Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change KeyErrors to Warnings when checking experiment identifier selection input #2119

Merged
merged 2 commits into from
May 25, 2022

Conversation

jbeilstenedmands
Copy link
Contributor

Changes the error handling when using experiment identifiers to select in a reflection table.

Fixes #2085

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #2119 (561be29) into main (25055c1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2119      +/-   ##
==========================================
- Coverage   80.38%   80.38%   -0.01%     
==========================================
  Files         580      580              
  Lines       65827    65827              
  Branches     9286     9284       -2     
==========================================
- Hits        52915    52914       -1     
  Misses      10853    10853              
- Partials     2059     2060       +1     

@jbeilstenedmands jbeilstenedmands merged commit 45fa91a into main May 25, 2022
@jbeilstenedmands jbeilstenedmands deleted the expt_identifiers_keyerror branch May 25, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overly Restrictive KeyError compares lengths instead of one list being a subset of another
2 participants